Merge branch 'main' into VACMS-20678-no-lh-csv

.ddev/config.yaml

@@ -43,7 +43,7 @@ web_environment:
     - CMS_MARIADB_USERNAME=db
     - CMS_MARIADB_PASSWORD=db
     - CMS_MARIADB_HOST=db
-    - CYPRESS_TAGS=\"not @ignore and not @piv\"
+    - CYPRESS_TAGS=\"not @piv\"
     - DDEV_APPROOT=/var/www/html
     - DRUPAL_ADDRESS=https://va-gov-cms.ddev.site
 nodejs_version: "16"
@@ -229,10 +229,6 @@ corepack_enable: false
 # If you prefer you can change this to "ddev.local" to preserve
 # pre-v1.9 behavior.
 
-# ngrok_args: --basic-auth username:pass1234
-# Provide extra flags to the "ngrok http" command, see
-# https://ngrok.com/docs/ngrok-agent/config or run "ngrok http -h"
-
 # disable_settings_management: false
 # If true, DDEV will not create CMS-specific settings files like
 # Drupal's settings.php/settings.ddev.php or TYPO3's AdditionalConfiguration.php

.github/CODEOWNERS

@@ -34,6 +34,7 @@
 /config/sync/*full_width_banner_alert*                              @department-of-veterans-affairs/facilities-cms
 # To catch VAMC stuff with older naming convention
 /config/sync/*health_care*                                          @department-of-veterans-affairs/facilities-cms
+/config/sync/*connect_with_us*                                      @department-of-veterans-affairs/public-websites-cms
 /config/sync/*jsonapi*                                              @department-of-veterans-affairs/accelerated-publishing
 # aka VAMC System Locations List
 /config/sync/*locations_listing*                                    @department-of-veterans-affairs/facilities-cms
@@ -80,6 +81,7 @@
 /docroot/modules/custom/va_gov_login                                # @department-of-veterans-affairs/platform-cms-drupal-engineers
 /docroot/modules/custom/va_gov_lovell                               @department-of-veterans-affairs/facilities-cms
 /docroot/modules/custom/va_gov_magichead                            @department-of-veterans-affairs/public-websites-cms
+/docroot/modules/custom/va_gov_manila                               @department-of-veterans-affairs/facilities-cms 
 /docroot/modules/custom/va_gov_media                                # @department-of-veterans-affairs/platform-cms-drupal-engineers
 /docroot/modules/custom/va_gov_menu_access                          # @department-of-veterans-affairs/platform-cms-drupal-engineers
 /docroot/modules/custom/va_gov_menus                                # @department-of-veterans-affairs/platform-cms-drupal-engineers

.github/ISSUE_TEMPLATE/ap-defect.md

@@ -1,46 +1,36 @@
 ---
-name: "(AP) Defect"
-about: Work to fix a problem with existing functionality
+name: "Next-Build Defect"
+about: Defect in next-build template migration
 title: "<Short description of the functional problem>"
-labels: Accelerated Publishing, Defect
+labels: next-build, Defect
 assignees: ''
 
 ---
 
-### What is the problem?
-<!-- Describe the problem in a few sentences or less, focusing on the functional issue rather than the technical failure. -->
+## Description
+<!-- Clearly describe the defect. -->
 
-### Who is affected?
-<!-- What is the user prevented from doing? About how many users are affected? -->
 
-### How urgent is the issue?
-Critical / Major / Minor
+### Reproduction steps
+URL of page where the defect is:
 
-```[tasklist]
-###
-- [ ] The problem as described is fixed
-- [ ] The repro steps result in 'expected result'
-- [ ] An automated test is written to catch the problem, if appropriate
-```
+<!-- Include environment, browser, OS if relevant. -->
+1. 
+2. 
+3. 
 
-### How can we see the problem? (repro steps)
-<!-- Please include environment, browser, operating system information if it is relevant. -->
-1. Please include a set of steps that allows an independent tester to see the problem.
-2. Write them so that after the defect is fixed, the steps will result in the expected result.
-3. It is helpful to write the steps methodically so they can be the foundation of an automated test.
+### Next-build Screen shot
 
-**Expected result:** What should be the outcome?<br />
-**Actual result:** What currently happens?
 
-### Is there any additional information?
-Screenshots:
+### Comparison to Prodcution
+<!-- Clearly describe the correct display or functionality that is different on Production that next-build should have. -->
 
-Log messages (please specify from where or what commands(s))
-```
-Log messages here
-```
+Example Production URL:
 
-### Why is the problem happening and how do we fix it?
-<!-- Provide any information about why the bug is happening. Links to tickets where the work was originally done are helpful. -->
-<!-- This is the place for info about the technical failure. -->
-<!-- This probably will not be filled out when the ticket is initially created. -->
+### Production Screen shot
+
+
+### Acceptance Criteria
+- [ ] Testable_Outcome_X
+- [ ] Testable_Outcome_Y
+- [ ] Testable_Outcome_Z

.github/ISSUE_TEMPLATE/ap-migration.md

@@ -0,0 +1,42 @@
+---
+name: "(AP) Next-build migration"
+about: Templates to be migrated to next-build
+title: "Next Build Template: "
+labels: Accelerated Publishing, Migration
+assignees: ''
+
+---
+
+## Template or Content Type
+_Name of template or content type_
+
+## Example
+_URL to show an example of the template or content type in both Drupal CMS and VA.gov_
+
+## Description
+_Overview of template or content type, including relevant details to the migration lift._
+
+## Product Owner 
+_The team that owns the product in production_
+
+## Definition of Done
+**Data:**
+- [ ] Conditional logic matches content-build / production 
+- [ ] SEO Metadata matches production
+- [ ] Analytics match production
+
+**Interaction / Behavior:**
+- [ ] Interactions / behavior match production (e.g. accordion expansion by default on page load if they do, data IDs on elements / their usage, link behavior, form / input field behaviors, etc) 
+
+**Accessibility:**
+- [ ] Accessibility experience matches production (voiceover/screen reader behavior, appearance at 400% zoom, params on elements, etc) 
+- [ ] axe devTools output matches production
+
+**Visual presentation:**
+- [ ] Design system components, prop usage and component versions match production
+- [ ] Design (font size, spacing, Anything else?) matches production
+- [ ] Review all breakpoints
+
+**Signoff / Launch**
+- [ ] Owning team has reviewed the build and provided feedback / approval
+- [ ] CMS Team has confirmed launch readiness 

.github/ISSUE_TEMPLATE/dark-launch.md

@@ -11,7 +11,7 @@ assignees: ''
 ## Description
 Use this issue to request dark launch of a CMS page that includes a React widget. 
 
-**Review documentation about the process** prior to submitting your ticket: https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/public-websites#3-publish-a-cms-page-only-to-staging-using-entityqueue-in-order-to-stage-cms--content-build--vets-website-for-viewing-off-of-va-network
+**Review documentation about the process** prior to submitting your ticket: [Dark launch Drupal content to Staging.va.gov](https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/public-websites#4-publish-a-cms-page-only-to-staging-using-entityqueue-in-order-to-stage-cms--content-build--vets-website-for-viewing-off-of-va-network)
 
 
 ### Staging/dark launch
@@ -32,12 +32,13 @@ CMS team does not want to get in the habit of having staged nodes that will not
 Please tick the boxes for completed steps as we go, for cross-team visibility.
 - [ ] Technical POC has merged vets-website code to main & confirmed deploy to prod
 - [ ] Add Node ID to [Staged Content entity subqueue](https://prod.cms.va.gov/admin/structure/entityqueue/staged_content/staged_content?destination=/admin/structure/entityqueue)
-- [ ] Strategic POC has given approval to publish node to Staging, or has published node
-- [ ] Nightly CMS build has run which pushes prod mirror to the staging site, or PW must request an out of band deployment.
-- [ ] Content-release has run. 
-- [ ] Verify on staging / prod
+- [ ] Strategic POC has given approval to publish node to Staging
+- [ ] Node is published with a revision log indicating dark launch and referencing this ticket #
+- [ ] Nightly CMS database sync from production to [content-build-branch-builds Tugboat](https://tugboat.vfs.va.gov/6189a9af690c68dad4877ea5) has run successfully
+- [ ] After the next merge to main in content-build, the [continuous integration Github action](https://github.com/department-of-veterans-affairs/content-build/actions/workflows/continuous-integration.yml) must run and be successful.
+- [ ] Verify: page is present on staging.va.gov and does not appear on va.gov (prod)
 
 ## Acceptance Criteria
-- [ ] Page is verified: Live on Staging
-- [ ] Page is **not** live on Prod
+- [ ] Page is verified: Live on staging.va.gov
+- [ ] Page is **not** live on VA.gov
 - [ ] Ticket is cut for production launch planning, e.g. #10627

.github/ISSUE_TEMPLATE/pw-injected-header.md

@@ -21,6 +21,9 @@ Public Websites team will need to:
 - [ ] add the domain with **both www and non-www** to the [proxy-rewrite-whitelist.json](https://github.com/department-of-veterans-affairs/vets-website/blob/main/src/applications/proxy-rewrite/proxy-rewrite-whitelist.json) allow list, with `"cookieOnly": true` for staging testing. - .5hr
 
 - [ ] add the domain to Devops code that handles the TeamSite CORS allowed origins for `bucket-prod-va-gov-assets` and `bucket-preview-va-gov-assets`. The buckets are now part of the vets-api module, so you just need to make sure any needed origins are in the local allowed_origins list: https://github.com/department-of-veterans-affairs/devops/blob/master/terraform/environments/dsva-vagov-prod/main.tf#L274 - .5hr
+    - [ ] In your Devops PR, add an "Additional Steps" section to the PR description with the following checkboxes for the devops person to take on upon approving the PR ([rationale from Devops in Slack](https://dsva.slack.com/archives/CBU0KDSB1/p1740086549724649?thread_ts=1740081681.905719&cid=CBU0KDSB1))
+        - [ ] Devops merged PR
+        - [ ] Devops ran terraform
 
 - [ ] PR shepherding - .5-1hr
 

.github/ISSUE_TEMPLATE/runbook---ux-research.md

@@ -18,14 +18,14 @@ assignees: ''
 **How to set up a new UX research epic**
 - [ ] Create a Research [Epic](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?assignees=&labels=Epic%2C+Needs+refining&template=cms-epic.md&title=%3CInsert+summary+of+epic%3E) for your product/initiative
 - [ ] Create a Research Folder following [Platform's Research guidance](https://depo-platform-documentation.scrollhelp.site/research-design/research-checklist#ResearchChecklist-1.Planningforresearch)
-- [ ] Create a [Research Discovery](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-discovery.md) issue
-- [ ] Create a [Research Plan](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-plan.md) issue
-- [ ] Create a [Research Conversation Guide](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-conversation-guide.md) issue
-- [ ] Create a [Research Collab Cycle](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-collab-cycle.md) issue
-- [ ] Create a [Research Prep](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-prep.md) issue
-- [ ] Create a [Research Sessions](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-sessions.md) issue
-- [ ] Create a [Research Synthesis and Reporting](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-synthesis-and-reporting.md) issue
-- [ ] Create a [Research Readout and Post-tasks](https://github.com/department-of-veterans-affairs/va.gov-cms/blob/main/.github/ISSUE_TEMPLATE/research-readout-and-post-tasks.md) issue
+- [ ] Create a [Research Discovery](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-discovery.md) issue
+- [ ] Create a [Research Plan](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-plan.md) issue
+- [ ] Create a [Research Conversation Guide](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-conversation-guide.md) issue
+- [ ] Create a [Research Collab Cycle](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-collab-cycle.md) issue
+- [ ] Create a [Research Prep](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-prep.md) issue
+- [ ] Create a [Research Sessions](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-sessions.md) issue
+- [ ] Create a [Research Synthesis and Reporting](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-synthesis-and-reporting.md) issue
+- [ ] Create a [Research Readout and Post-tasks](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/new?template=research-readout-and-post-tasks.md) issue
 - [ ] Add all the above issues to the Research Epic and add dependencies
 
 ## Acceptance Criteria

.github/ISSUE_TEMPLATE/runbook-facility-url-change.md

@@ -3,7 +3,7 @@ name: Runbook - Facility URL Change
 about: Submit a request to change the URL of a facility
 title: 'URL Change for: <insert facility name>'
 labels: Drupal engineering, Facilities, Flagged Facilities, Redirect request, User
-  support
+  support, sitewide
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/runbook-nca-facility-closed.md

@@ -3,7 +3,7 @@ name: Runbook - NCA Facility closed
 about: Steps for archiving a NCA facility in VA.gov CMS.
 title: 'NCA Facility closed: <insert_name>'
 labels: Change request, Drupal engineering, Facilities, Flagged Facilities, NCA, User
-  support
+  support, sitewide
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/runbook-nca-facility-name-change.md

@@ -3,7 +3,7 @@ name: Runbook - NCA Facility name change
 about: Steps for updating names and URLs
 title: 'NCA Facility name change: <insert_name>'
 labels: Change request, Drupal engineering, Facilities, Flagged Facilities, NCA, User
-  support
+  support, sitewide
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/runbook-nca-facility-new.md

@@ -3,7 +3,7 @@ name: Runbook - New NCA Facility
 about: changing facility information in the CMS for NCA facilities
 title: 'New NCA Facility: <insert_name_of_facility>'
 labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
-  VBA
+  VBA, sitewide
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/runbook-new-vamc-system.md

@@ -116,12 +116,12 @@ assignees: ''
 ### Menu configuration and clean up [CMS helpdesk or Sitewide team]
 - [ ] Go to [Content / Menus](https://prod.cms.va.gov/admin/structure/menu)
 - [ ] Find the relevant menu and select edit menu
-- [ ] Ensure all menu links are nested in the proper place
-- [ ] Set some menu links to disabled 
-- [ ] Consult [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh) for menu settings (Here's a [backup static copy](https://github.com/department-of-veterans-affairs/va.gov-team/blob/1b010e72b992dbefa7305764b0058841131733bc/products/facilities/medical-centers/VAMC-Sitemap.xlsx) in case of access issues in the future)  
+- [ ] Ensure all menu links are nested in the proper place by opening each menu item individually and ensuring it has the correct parent link, and saving
+- [ ] Set some menu links to disabled, according to the [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh) 
+- [ ] Consult [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh) for menu settings (Here's a [backup static copy](https://github.com/department-of-veterans-affairs/va.gov-team/blob/1b010e72b992dbefa7305764b0058841131733bc/products/facilities/medical-centers/VAMC-Sitemap.xlsx) in case of access issues in the future)
 
 ### URL alias configuration [CMS helpdesk or Sitewide team]
-- [ ] Check that each page has the correct URL alias matching the [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh)
+- [ ] Check that each page has the correct URL alias matching the [VAMC sitemap in sharepoint](https://dvagov.sharepoint.com/:x:/s/SitewideContract/EblgAS21OUtHloKK3a8ZvNIBHzV1S6uO2l4hj4dqYG0avQ?e=J8UVZh), and breadcrumb
 - [ ] If pages dont have the correct URL Alias, change them from Auto to Manual and input the correct URL alias
 
 ### User set up [CMS helpdesk]
@@ -132,9 +132,11 @@ assignees: ''
 ### VAMC editor tasks
 - [ ] Complete training if they haven't already
 - [ ] Follow the instructions in [VAMC editor guide](https://prod.cms.va.gov/help/vamc)
-- [ ] Confirm when ready to publish
+- [ ] Advise the Editor not to publish content until all drafts, including Top Task pages, are ready to Publish.
+- [ ] Ask the Editor to confirm when they are ready for Helpdesk / Sitewide to publish the site
 
-### Launch tasks
-- [ ] Lighthouse coordination for service push?
-- [ ] Redirects? 
-- [ ] Comms, change management?
+### Launch tasks [CMS helpdesk or Sitewide team]
+- [ ] Bulk publish content in a Tugboat and re-verify URLs, menu items / parents / structure, and breadcrumbs
+- [ ] Coordinate timing with Editor for a bulk publish of all ready content in production, including Top Task pages
+- [ ] If there is a legacy site for the system, or if existing facilities move into the new system, create a ticket for the appropriate redirects
+- [ ] Notify the Editor that the site is published

.github/ISSUE_TEMPLATE/runbook-vamc-facility-closed.md

@@ -3,7 +3,7 @@ name: Runbook - VAMC Facility closed
 about: Steps for archiving a VAMC facility in VA.gov CMS.
 title: 'VAMC Facility closed: <insert_name>'
 labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
-  VAMC
+  VAMC, sitewide
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/runbook-vamc-facility-duplicate-or-section-change.md

@@ -3,7 +3,7 @@ name: Runbook - VAMC facility duplicate record or section change
 about: How to update the section of a VAMC.
 title: 'VAMC Facility duplicate record or section change: <insert_name_of_vamc>'
 labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
-  VAMC
+  VAMC, sitewide
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/runbook-vamc-facility-name-change.md

@@ -3,7 +3,7 @@ name: Runbook - VAMC Facility name change
 about: Steps for updating names and URLs
 title: 'VAMC Facility name change: <insert_name>'
 labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
-  VAMC
+  VAMC, sitewide
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/runbook-vamc-facility-new.md

@@ -3,7 +3,7 @@ name: Runbook - New VAMC Facility
 about: changing facility information in the CMS for VAMC facilities
 title: 'New VAMC Facility: <insert_name_of_facility>'
 labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
-  VAMC
+  VAMC, sitewide
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/runbook-vamc-system-name-change.md

@@ -3,7 +3,7 @@ name: Runbook - VAMC system name change
 about: How to update the name of a VAMC.
 title: 'VAMC system name change: <insert_name_of_vamc>'
 labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
-  VAMC
+  VAMC, sitewide
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/runbook-vba-facility-closed.md

@@ -3,7 +3,7 @@ name: Runbook - VBA Facility closed
 about: Steps for archiving a VBA facility in VA.gov CMS.
 title: 'VBA Facility closed: <insert_name>'
 labels: Change request, Drupal engineering, Facilities, Flagged Facilities, User support,
-  VBA
+  VBA, sitewide
 assignees: ''
 
 ---