Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding non-urgent message alert to secure messaging form #10448

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jmarchi
Copy link
Contributor

@jmarchi jmarchi commented Feb 26, 2025

Description of Change

Added an informational alert to the secure message form that the messaging feature is meant for non urgent messages.

Screenshots/Video

image

Testing

Added a unit test for the display of the alert.

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

Copy link
Contributor

@dumathane dumathane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some notes.

I'm also interested if anyone asked if we should be applying a similar message to reply's or editing drafts as they are technically different screens. I'd assume the start new message is the important one it should apply to, but want to hit parity if we can with the web teams.

Also did anyone ask if we should be removing the old place we housed this notice? I might start a thread today with those questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants