-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/8936-UseDesignSystemLoadingComponent #10392
Merged
oddballdave
merged 12 commits into
develop
from
chore/8936-UseDesignSystemLoadingComponent
Mar 6, 2025
Merged
chore/8936-UseDesignSystemLoadingComponent #10392
oddballdave
merged 12 commits into
develop
from
chore/8936-UseDesignSystemLoadingComponent
Mar 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Moving back to draft until this DS library issue is fixed. |
56986ef
to
dcdf56d
Compare
8 tasks
matt-guest-wilcore
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested on both iOS and Android and everything looks good. Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Incorporated the Design System LoadingIndicator component into the app. This is a partial replacement for the existing app-supplied LoadingComponent which handled these scenarios:
This work only covers scenario 3 because the Design System LoadingIndicator does not provide a way to customize it for the other two cases. Furthermore, to center the LoadingIndicator vertically on the screen it had to be wrapped by the existing app-supplied LoadingComponent.
After implementing these changes, all detox/e2e screen tests that showed the loading component started to fail. Research and experimentation showed that the animation logic in the component was flawed, so this was adjusted to a cleaner/safer implementation so the tests would function normally.
Screenshots/Video
Android (Before)
iOS (Before)
Android (After)
iOS (After)
Testing
Reviewer Validations
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch