Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/8936-UseDesignSystemLoadingComponent #10392

Merged
merged 12 commits into from
Mar 6, 2025

Conversation

oddballdave
Copy link
Contributor

@oddballdave oddballdave commented Dec 17, 2024

Description of Change

Incorporated the Design System LoadingIndicator component into the app. This is a partial replacement for the existing app-supplied LoadingComponent which handled these scenarios:

  1. Showing a spinner only with a custom color.
  2. Showing an inline spinner with a customized color and size.
  3. Showing a spinner with text below it.

This work only covers scenario 3 because the Design System LoadingIndicator does not provide a way to customize it for the other two cases. Furthermore, to center the LoadingIndicator vertically on the screen it had to be wrapped by the existing app-supplied LoadingComponent.

After implementing these changes, all detox/e2e screen tests that showed the loading component started to fail. Research and experimentation showed that the animation logic in the component was flawed, so this was adjusted to a cleaner/safer implementation so the tests would function normally.

Screenshots/Video

Android (Before)
iOS (Before)
Android (After)
iOS (After)

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@oddballdave oddballdave linked an issue Dec 17, 2024 that may be closed by this pull request
@oddballdave oddballdave marked this pull request as ready for review December 20, 2024 18:06
@oddballdave oddballdave requested review from a team as code owners December 20, 2024 18:06
@oddballdave
Copy link
Contributor Author

Moving back to draft until this DS library issue is fixed.

@oddballdave oddballdave force-pushed the chore/8936-UseDesignSystemLoadingComponent branch from 56986ef to dcdf56d Compare January 10, 2025 20:17
@Eallan919
Copy link

These PR's are blocked because they depend on updating the DS Library with the previously mentioned PR's and they also need to have a final review by an authorized user: #10298 & #10392.

@oddballdave oddballdave marked this pull request as ready for review February 26, 2025 13:50
Copy link
Contributor

@matt-guest-wilcore matt-guest-wilcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on both iOS and Android and everything looks good. Approved!

@oddballdave oddballdave merged commit 506fdc9 into develop Mar 6, 2025
44 of 72 checks passed
@oddballdave oddballdave deleted the chore/8936-UseDesignSystemLoadingComponent branch March 6, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate new Loading Component into the App - Global
3 participants