VAMS-20163 news release contact number #919
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,7 +34,22 @@ exports[`node--press_release formatData output formatted data 1`] = ` | |
| "uri": "https://content-build-medc0xjkxm4jmpzxl3tfbcs7qcddsivh.ci.cms.va.gov/wilmington-health-care/news-releases/wilmington-vamc-2019-annual-report", | ||
| }, | ||
| ], | ||
| "contacts": [ | ||
| { | ||
| "description": "Public Affairs Specialist", | ||
| "email": "[email protected]", | ||
| "id": "7ecb5154-7e2c-4c16-a171-bb3710a4dab7", | ||
| "name": "Sheila Tunney", | ||
| "numbers": [ | ||
| { | ||
| "ext": null, | ||
| "id": "a96f65e2-5a82-4b59-b249-25c634e93108", | ||
| "number": "412-360-1479", | ||
| "type": "phone", | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| "downloads": [], | ||
| "entityId": 18141, | ||
| "entityPath": "/wilmington-health-care/news-releases/wilmington-vamc-2019-annual-report", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -368,7 +368,170 @@ | |
| } | ||
| } | ||
| }, | ||
| "field_press_release_contact": [ | ||
| { | ||
| "type": "node--person_profile", | ||
| "id": "7ecb5154-7e2c-4c16-a171-bb3710a4dab7", | ||
| "drupal_internal__nid": 94, | ||
| "drupal_internal__vid": 988884, | ||
| "sticky": false, | ||
| "default_langcode": true, | ||
| "langcode": "en", | ||
| "status": true, | ||
| "title": "Sheila Tunney", | ||
| "created": "2019-02-26T05:47:15+00:00", | ||
| "changed": "2024-11-25T18:00:07+00:00", | ||
| "breadcrumbs": [ | ||
| { | ||
| "uri": "https://content-build-medc0xjkxm4jmpzxl3tfbcs7qcddsivh.ci.cms.va.gov/", | ||
| "title": "Home", | ||
| "options": [] | ||
| }, | ||
| { | ||
| "uri": "https://content-build-medc0xjkxm4jmpzxl3tfbcs7qcddsivh.ci.cms.va.gov/pittsburgh-health-care", | ||
| "title": "VA Pittsburgh Health Care", | ||
| "options": [] | ||
| }, | ||
| { | ||
| "uri": "https://content-build-medc0xjkxm4jmpzxl3tfbcs7qcddsivh.ci.cms.va.gov/pittsburgh-health-care/staff-profiles/sheila-tunney", | ||
| "title": "Sheila Tunney", | ||
| "options": [] | ||
| } | ||
| ], | ||
| "moderation_state": "published", | ||
| "expiration_date": null, | ||
| "warning_date": null, | ||
| "metatag": [ | ||
| { | ||
| "tag": "meta", | ||
| "attributes": { | ||
| "name": "title", | ||
| "content": "Sheila Tunney | VA Pittsburgh health care | Veterans Affairs" | ||
| } | ||
| }, | ||
| { | ||
| "tag": "link", | ||
| "attributes": { | ||
| "rel": "image_src", | ||
| "href": "https://www.va.gov/img/design/logo/va-og-image.png" | ||
| } | ||
| }, | ||
| { | ||
| "tag": "meta", | ||
| "attributes": { | ||
| "property": "og:site_name", | ||
| "content": "Veterans Affairs" | ||
| } | ||
| }, | ||
| { | ||
| "tag": "meta", | ||
| "attributes": { | ||
| "property": "og:title", | ||
| "content": "Sheila Tunney | VA Pittsburgh health care | Veterans Affairs" | ||
| } | ||
| }, | ||
| { | ||
| "tag": "meta", | ||
| "attributes": { | ||
| "name": "twitter:card", | ||
| "content": "summary_large_image" | ||
| } | ||
| }, | ||
| { | ||
| "tag": "meta", | ||
| "attributes": { | ||
| "name": "twitter:site", | ||
| "content": "@DeptVetAffairs" | ||
| } | ||
| }, | ||
| { | ||
| "tag": "meta", | ||
| "attributes": { | ||
| "name": "twitter:title", | ||
| "content": "Sheila Tunney | VA Pittsburgh health care | Veterans Affairs" | ||
| } | ||
| } | ||
| ], | ||
| "path": { | ||
| "alias": "/pittsburgh-health-care/staff-profiles/sheila-tunney", | ||
| "pid": 214, | ||
| "langcode": "en" | ||
| }, | ||
| "field_body": null, | ||
| "field_complete_biography_create": false, | ||
| "field_description": "Public Affairs Specialist", | ||
| "field_email_address": "[email protected]", | ||
| "field_intro_text": null, | ||
| "field_last_name": "Tunney", | ||
| "field_last_saved_by_an_editor": "2024-05-02T13:03:19+00:00", | ||
| "field_meta_tags": null, | ||
| "field_name_first": "Sheila", | ||
| "field_photo_allow_hires_download": false, | ||
| "field_suffix": null, | ||
| "links": { | ||
| "self": { | ||
| "href": "https://content-build-medc0xjkxm4jmpzxl3tfbcs7qcddsivh.ci.cms.va.gov/jsonapi/node/person_profile/7ecb5154-7e2c-4c16-a171-bb3710a4dab7?resourceVersion=id%3A934975" | ||
| } | ||
| }, | ||
| "node_type": { | ||
| "type": "node_type--node_type", | ||
| "id": "89b07673-7fd5-4292-8fba-58cc10c4e3ec", | ||
| "resourceIdObjMeta": { | ||
| "drupal_internal__target_id": "person_profile" | ||
| } | ||
| }, | ||
| "field_administration": { | ||
| "type": "taxonomy_term--administration", | ||
| "id": "87832236-1e54-4ce3-8141-8dec27c8a9a7", | ||
| "resourceIdObjMeta": { | ||
| "drupal_internal__target_id": 12 | ||
| } | ||
| }, | ||
| "field_complete_biography": null, | ||
| "field_media": null, | ||
| "field_office": null, | ||
| "field_telephone": { | ||
| "type": "paragraph--phone_number", | ||
| "id": "a96f65e2-5a82-4b59-b249-25c634e93108", | ||
| "drupal_internal__id": 163647, | ||
| "drupal_internal__revision_id": 1561519, | ||
| "langcode": "en", | ||
| "status": true, | ||
| "created": "2024-11-25T18:00:06+00:00", | ||
| "parent_id": "94", | ||
| "parent_type": "node", | ||
| "parent_field_name": "field_telephone", | ||
| "behavior_settings": [], | ||
| "default_langcode": true, | ||
| "revision_translation_affected": null, | ||
| "breadcrumbs": [], | ||
| "content_translation_source": "und", | ||
| "content_translation_outdated": false, | ||
| "content_translation_changed": "2024-11-25T18:00:06+00:00", | ||
| "field_phone_extension": null, | ||
| "field_phone_label": null, | ||
| "field_phone_number": "412-360-1479", | ||
| "field_phone_number_type": "phone", | ||
| "links": { | ||
| "self": { | ||
| "href": "https://content-build-medc0xjkxm4jmpzxl3tfbcs7qcddsivh.ci.cms.va.gov/jsonapi/paragraph/phone_number/a96f65e2-5a82-4b59-b249-25c634e93108?resourceVersion=id%3A1561519" | ||
| } | ||
| }, | ||
| "resourceIdObjMeta": { | ||
| "target_revision_id": 1561519, | ||
| "drupal_internal__target_id": 163647 | ||
| }, | ||
| "paragraph_type": { | ||
| "type": "paragraphs_type--paragraphs_type", | ||
| "id": "9c5d2698-f605-42f2-a516-15949b84d17f", | ||
| "resourceIdObjMeta": { | ||
| "drupal_internal__target_id": "phone_number" | ||
| } | ||
| }, | ||
| "relationshipNames": ["paragraph_type"] | ||
| } | ||
| } | ||
| ], | ||
| "field_press_release_downloads": [], | ||
| "field_administration": { | ||
| "drupal_internal__tid": 188, | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 What happens if these are false-y? I can't think of a reason we'd ever want empty strings for any of these, but this will turn those empty strings into
null. 🤔 Probably fine? 🤷There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was also dubious about this, but was trying to follow style/pattern. Getting existential about the identity of a defect ticket, it was feeling weird to shift that style for this work. Mostly because I would then feel the need to change other un-related areas to match. I think next steps around this sort of thing for me at least would be to hook my local drupal up to local next to start playing around with different missing data states.