Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added code to reuse Ixia Traffic Gen Session #174

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Added code to reuse Ixia Traffic Gen Session #174

merged 1 commit into from
Mar 7, 2023

Conversation

vikumarks
Copy link
Collaborator

Added code to reuse Ixia Traffic Gen Session, if session already exists use it else create new session.
This PR will address the Session initialization Portion of #155

@vikumarks @vkuma82
Update ixnetwork_ixia_client_impl.py (#1)
365c29e 
Signed-off-by: Vinod Kumar <[email protected]>
Co-authored-by: vkuma82 <[email protected]>
@vikumarks vikumarks requested review from mgheorghe and muchetan March 4, 2023 01:30
@mgheorghe mgheorghe requested review from anton7811 and removed request for muchetan March 4, 2023 01:31
@anton7811
Copy link
Contributor

Hi @vikumarks!
Does it solve also the question of reconfiguring L1 ports during each tgen_utils_traffic_generator_connect call (TrafficGen.connect call)?
I would like to understand how this PR addresses #155 and how timings are improved.
Thank you!

@vkuma82
Copy link
Contributor

vkuma82 commented Mar 6, 2023

Hi @vikumarks! Does it solve also the question of reconfiguring L1 ports during each tgen_utils_traffic_generator_connect call (TrafficGen.connect call)? I would like to understand how this PR addresses #155 and how timings are improved. Thank you!

Hi @anton7811!
This will not solve reconfiguring L1 ports, but it will save time (10~15 secs) for each test after the first test, by reusing the existing session for subsequent tests.

@anton7811
Copy link
Contributor

@vikumarks So let's merge this and keep issue #155 opened for now.
Thank you!

@mgheorghe mgheorghe merged commit 8d2a92f into dentproject:main Mar 7, 2023
yuriilisovskyi referenced this pull request in PLVision/dent-testing Mar 30, 2023
@vikumarks @vkuma82 @yuriilisovskyi
Update ixnetwork_ixia_client_impl.py (#1) (#174)
ab3625a 
Signed-off-by: Vinod Kumar <[email protected]>
Co-authored-by: vkuma82 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton7811 anton7811 anton7811 approved these changes

@mgheorghe mgheorghe mgheorghe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vikumarks @anton7811 @vkuma82 @mgheorghe