feat: "deno.logFile" setting (#1003)

denoland · Dec 8, 2023 · 1f7f580 · 1f7f580
1 parent 40bd148
commit 1f7f580
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 0 deletions.
diff --git a/client/src/extension.ts b/client/src/extension.ts
@@ -58,6 +58,7 @@ const workspaceSettingsKeys: Array<keyof Settings> = [
   "inlayHints",
   "internalDebug",
   "lint",
+  "logFile",
   "path",
   "suggest",
   "testing",
@@ -177,6 +178,7 @@ function handleConfigurationChange(event: vscode.ConfigurationChangeEvent) {
       event.affectsConfiguration("deno.enable") ||
       event.affectsConfiguration("deno.disablePaths") ||
       event.affectsConfiguration("deno.enablePaths") ||
+      event.affectsConfiguration("deno.logFile") ||
       event.affectsConfiguration("deno.path") ||
       event.affectsConfiguration("deno.maxTsServerMemory")
     ) {

diff --git a/client/src/shared_types.d.ts b/client/src/shared_types.d.ts
@@ -104,6 +104,7 @@ export interface Settings {
   internalDebug: boolean;
   /** Determine if the extension should be providing linting diagnostics. */
   lint: boolean;
+  logFile: boolean;
   /** Specify an explicit path to the `deno` binary. */
   path: string | null;
   // TODO(nayeemrmn): Deprecate the `Suggest` part of this in favour of

diff --git a/package.json b/package.json
@@ -475,6 +475,16 @@
             false
           ]
         },
+        "deno.logFile": {
+          "type": "boolean",
+          "default": false,
+          "markdownDescription": "Write logs to a file in a project-local directory.",
+          "scope": "window",
+          "examples": [
+            true,
+            false
+          ]
+        },
         "deno.defaultTaskCommand": {
           "type": "string",
           "enum": [

diff --git a/typescript-deno-plugin/src/index.ts b/typescript-deno-plugin/src/index.ts
@@ -45,6 +45,7 @@ const defaultSettings: Settings = {
   inlayHints: null,
   internalDebug: false,
   lint: false,
+  logFile: false,
   path: null,
   suggest: {
     autoImports: true,