-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poll_* methods to support custom futures implementations #78
Open
dgrr
wants to merge
27
commits into
denoland:main
Choose a base branch
from
dgrr:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
5f1d0e5
frame: Use abstract trait to write the header to
dgrr 9ea19e6
Implement poll* methods to support future-based systems
dgrr 3c779ff
Merge branch 'main' of github.com:dgrr/fastwebsockets
dgrr 7fc1617
poll methods for WebSocketStream
dgrr f1696f1
WebSocket: start_send_frame function
dgrr 30c1586
Cargo.toml: futures version
dgrr 909cd67
Cargo.toml: tokio_util version
dgrr 78f81dd
Set the waker before flushing
dgrr 23a7101
Implement poll_read_frame & poll_write_frame for WebSocketRead and We…
dgrr 59904ad
Bring back unstable-split feature
dgrr 8285b55
write_frame: Check readiness of the underlying connection by flushing…
dgrr 3f050bf
Function docs
dgrr b7b7696
Fix return type when not using SIMD for utf8 processing
dgrr b1b087c
Generate state machine for reading
dgrr 3636e5b
WriteHalf: Advance buffer on poll_ready
dgrr 3a537e3
Simplify loop by conradludgate
dgrr da4f6d7
use vec
conradludgate 9abbf6c
better buffer manipulation
conradludgate e91e922
re-introduce vectored writes
conradludgate 5d45077
refactor
conradludgate 1d579a1
Use a Vec<u8> instead of BytesMut for the write buffer
dgrr 988cbd5
Merge branch 'main' into dgrr/main
dgrr 53b2b96
Merge pull request #1 from conradludgate/dgrr/main
dgrr 28c331a
Remove underscore from used variable names
dgrr 7656018
Added test to check that simple and vectored serialization do not con…
dgrr b960f15
WebSocket: Handle obligated send flushing with states to ensure delivery
dgrr 9eebea5
Merge branch 'denoland:main' into main
dgrr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional to remove
unstable-split
? I would like to keep itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can put it back in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, the question is, why is it unstable?