Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use concrete errors and use deno_error #147

Merged
merged 11 commits into from
Jan 8, 2025
Merged

feat: use concrete errors and use deno_error #147

merged 11 commits into from
Jan 8, 2025

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Dec 12, 2024 •
edited by dsherret
Loading

Closes #117

dsherret
dsherret reviewed Dec 12, 2024
View reviewed changes
src/deno_json/mod.rs Outdated Show resolved Hide resolved
dsherret
dsherret reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we just need to update a few more things to use source

dsherret
dsherret reviewed Jan 6, 2025
View reviewed changes
src/workspace/mod.rs Outdated Show resolved Hide resolved
dsherret
dsherret reviewed Jan 6, 2025
View reviewed changes
src/workspace/mod.rs Outdated Show resolved Hide resolved
dsherret
dsherret approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with comments.

@crowlKats crowlKats merged commit ef30ea9 into main Jan 8, 2025
4 checks passed
@crowlKats crowlKats deleted the error-rework branch January 8, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to not use anyhow
2 participants
@crowlKats @dsherret