Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Optional Field names and Plugin Upgrade #38

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

camrossi
Copy link

@camrossi camrossi commented Dec 9, 2024

I have added the capability to support Optional fields as per

Additionally in my lab/tests I was getting many errors and warning about outdated libraries and neo4j wasn't even staring (not sure why) so I ended up:

  • Upgrading the Grafana SDK plugin
  • Upgrading the neo4j image as well as the Grafana one

I have tried (and failed) to update the testing:

  • As per the latest neo4j doc the ID field is deprecated and replaced by Entity ID
  • Both ID and Entity ID are not safe to track data out of the scope of a single transaction this breaks the testing as we are comparing the IDs. see
  • I have manage to fix this for runNeo4JIntegrationGraphTest by dropping the returned IDs i.e.
     nodeFrame := res.Frames[0]
     nodeFrame.Fields = nodeFrame.Fields[1:]
    
     edgeFrame := res.Frames[1]
     edgeFrame.Fields = edgeFrame.Fields[3:]
    

however I can't understand how to do the same for the runNeo4JIntegrationTableTest I spend hours trying and I just can't get it to work... as mentioned in the issue I just learned go so I did the best I could...

I have tested this PR with Grafana v11.3.0 and it is working as expected:

Here an example where I am setting 'mainstat'

image

Edit: I know I need to un-do the changes in the CICD files !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant