#4 Integrates arxiv2notionplus #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denkiwakame
commented
Jan 8, 2024
| const authors = authorsFormatted.split(', '); | ||
| const authorsMultiSelect = authors.map((author) => { | ||
| return { name: author }; | ||
| }); |
There was a problem hiding this comment.
denkiwakame
commented
Jan 8, 2024
| this.setFormContents(paperTitle, abst, authors); | ||
| return { title: paperTitle, abst: abst, authors: authors, url: url }; | ||
| const published = entry.querySelector('published').textContent; | ||
| const comment = entry.querySelector('comment')?.textContent ?? 'none'; |
There was a problem hiding this comment.
refactored: https://github.com/wangjksjtu/arxiv2notionplus/blob/main/src/js/popup.js#L129-L136
we can use ``??'' to write the same process in a single line.
denkiwakame
commented
Jan 8, 2024
| <!-- type="text" --> | ||
| <!-- placeholder="published" --> | ||
| <!-- ></input> --> | ||
| <!-- </div> --> |
There was a problem hiding this comment.
I decided not to display "published" field in the user interface because:
- this field should not be edted by hand.
- maximum height of the popup window is limited (600px)
denkiwakame
commented
Jan 8, 2024
| id="js-save" | ||
| class="uk-icon-button uk-icon-large uk-align-center uk-margin-small" | ||
| uk-icon="bookmark" | ||
| /> |
There was a problem hiding this comment.
I decided to change "save button" position to top of the popup window.
I found that most of users click only "databases" and "save"
This was referenced Jan 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4
semantic-releasesince this repository release is not so active)popup.html auto-resize not working ... ?-> chrome-ext has a maximum-size limit.