Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Recipes app - Final PR 🎫 #26

Merged
merged 89 commits into from
Dec 22, 2023
Merged

My Recipes app - Final PR 🎫 #26

merged 89 commits into from
Dec 22, 2023

Conversation

ITurres
Copy link
Collaborator

@ITurres ITurres commented Dec 22, 2023

recipes-app-logo-png-small

Pull Request Summary for Recipe App Project Completion

completed the following project requirements 🎯


  • A login page.
  • A registration page.
  • A recipe list (with all CRUD implementation, except for 'update').
  • A list of all public recipes from other users with their names and total prices.

If your team has fewer than 3 members you should implement:

  • A food list (with all CRUD implementation, except for 'update').

  • A general shopping list view (all missing food for all your recipes and total price).

  • You should follow the layout of the wireframes provided. You should personalize the rest of the design including colors, typographies, spacings, etc.

  • Login page and registration page:

    • Should be built with Devise.
  • Recipes list:

    • Should display a list of recipes created by the logged-in user as in the wireframe.
    • Should lead to recipe details.
  • Public recipe list:

    • Should display a list of all public recipes ordered by the newest as in the wireframe.
    • Should lead to recipe details.
    • If the user owns the recipe, should allow the user to delete it.
  • Recipe details:

    • Should display a toggle button that allows for a recipe to be made public or private.
    • If the recipe is public or the user owns the recipe, should display the recipe details as in the wireframe.
    • If the user is the owner of the recipe, should lead to the form that allows the user to add new food.
  • Food list:

    • Should display a list of food added by the logged-in user as in the wireframe (display also quantity of a given food).
    • Should lead to a form that allows users to add new food.
  • General shopping list view:

    • Should show the list of food that is missing for all recipes of the logged-in user (compare the list of food for all recipes with the general food list of that user).

    • Should count the total food items and total price of the missing food.

    • Make sure no N+1 queries are happening.

  • Create a navigation menu allowing users to open all the pages you created.

  • Write unit and integration tests

Technical setup

  • Set up the repository on GitHub and use Gitflow.
  • Set up Devise for authentication.
  • Set up RSpec and Capybara testing libraries.

Workload distribution (tickets) 🎫

Kanban Board: Ruby on Rails Team Project - My Recipes app


We @ITurres and @demesameneshoa thank you for reviewing this PR. Please feel free to reach out on Slack as Arturo (Arthur) Emanuel Guerra Iturres and Demes Ameneshoa for any questions or help you might have. 🌟

demesameneshoa and others added 30 commits December 18, 2023 22:57
- devise dependency
- rspec dependency
- and capybara dependency
 - Change the user model by setting devise confrimable
 - add confirmation fields to the database
- Require user authentication for all actions.
- Add 'current_user' to 'foods#create' action.
- Replace notices with flash messages.
- Remove 'user_id' from private 'foods#food_params'.
- Also wrap yield in a div with class 'container'.
- _food partial.
- _form partial.
- index view.
- new view.
@ITurres ITurres added documentation Improvements or additions to documentation enhancement New feature or request Project Setup Dependencies Installation and Linters Setup Tests Unit Test and Integration Test UI Views and Interfaces labels Dec 22, 2023
Copy link

@gemmen29 gemmen29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights 💯

  • No linters errors ✔️
  • Descriptive pull request ✔️

Optional suggestions

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ITurres
Copy link
Collaborator Author

ITurres commented Dec 22, 2023

Hi @gemmen29 George! We thank you so much for having taken the time to review such long PR 😁✨

We wish you a great end of week and happy holidays! 🏖

@ITurres ITurres merged commit 5a396f4 into master Dec 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request Project Setup Dependencies Installation and Linters Setup Tests Unit Test and Integration Test UI Views and Interfaces
Projects
Development

Successfully merging this pull request may close these issues.

3 participants