-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Recipes app - Final PR 🎫 #26
Conversation
- devise dependency - rspec dependency - and capybara dependency
Project Setup
- Change the user model by setting devise confrimable - add confirmation fields to the database
Issue #15 🎫: Models and Junction tables.
User Registration Implementation
Issue #5 🎫: Login page
- Require user authentication for all actions. - Add 'current_user' to 'foods#create' action. - Replace notices with flash messages. - Remove 'user_id' from private 'foods#food_params'.
- Also wrap yield in a div with class 'container'.
- _food partial. - _form partial. - index view. - new view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Team,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights 💯
- No linters errors ✔️
- Descriptive pull request ✔️
Optional suggestions
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @gemmen29 George! We thank you so much for having taken the time to review such long PR 😁✨ We wish you a great end of week and happy holidays! 🏖 |
Pull Request Summary for Recipe App Project Completion
completed the following project requirements 🎯
If your team has fewer than 3 members you should implement:
A food list (with all CRUD implementation, except for 'update').
A general shopping list view (all missing food for all your recipes and total price).
You should follow the layout of the wireframes provided. You should personalize the rest of the design including colors, typographies, spacings, etc.
Login page and registration page:
Recipes list:
Public recipe list:
Recipe details:
Food list:
General shopping list view:
Should show the list of food that is missing for all recipes of the logged-in user (compare the list of food for all recipes with the general food list of that user).
Should count the total food items and total price of the missing food.
Make sure no N+1 queries are happening.
Create a navigation menu allowing users to open all the pages you created.
Write unit and integration tests
Technical setup
Workload distribution (tickets) 🎫
Kanban Board: Ruby on Rails Team Project - My Recipes app
We @ITurres and @demesameneshoa thank you for reviewing this PR. Please feel free to reach out on Slack as Arturo (Arthur) Emanuel Guerra Iturres and Demes Ameneshoa for any questions or help you might have. 🌟