-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: join growing community section #17
Conversation
✅ Deploy Preview for deltahacks11 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Shivermist assets for yellow and red dinos are good but the blue dino and the trails I got from Figma are pretty low res. Do you have higher quality ones you could send? |
What should we do about this? @Shivermist are you able to extend the trail? Or should I just stretch it out more on wide screens? |
Waiting for #2 before reviewing this |
Hi
Hi Owen! I've uploaded high quality versions of the assets on the google drive under "Design --> Website assets" and the trails are under it's own folder there. Also the trials are supposed to svgs unless there's some kind of visual artifacts that makes it look weird. Do let me know if that's the case. Thanks! |
I've also extended the trails considerably on the Figma (assets also available on the drive). If it's still not long enough, feel free to stretch it out to fit on the screen. |
Thanks @Shivermist! I updated this PR to use assets from the drive. @kabirsg I also fixed that issue with the trail showing up over the tree. |
It looks great now thanks Owen! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@owengretzinger Please install and setup the appropriate font for this section, otherwise this looks great!
Updated other headers and added the font (see updated screenshots) |
fixed @Krish120003 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Krish120003 I changed the background color to make it match more. However, there's still a little line, which I think is because of a shadow baked into a hero section svg. The Figma design also has a subtle gradient throughout the whole page. But I think that these things are outside the scope of this PR. Let me know what you think. |
TL;DR
Created the join a growing community section. Closes #6.
What changed?
JoinGrowingCommunity.tsx
component with the content for the sectionHeader.tsx
component (and changed other sections to use this component)index.tsx
Other Notes
index.tsx
so that the purple background is a lower z-index. This way, we can easily add-z-10
to graphics and they will automatically show up in front of the purple background, but stay behind any other elements such as text.Screenshots
Desktop:
Mobile:
Extra Wide Screen:
How to test?