-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hero component #13
Conversation
✅ Deploy Preview for deltahacks11 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The fire animation gif is highly resource intensive and causes lag. |
The MLH Logo is too bold. |
The header font does not match Figma |
This helps temporarily with the performance issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of performance work that we could do, and we should avoid using px values as definitions and stick to em's for sizing. However, this is a functional hero and looks good for the initial release due to short deadlines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit, small cleaning to do but functionality complete
@Shivermist is this ok? How should this be handeled? |
Could the text be resized to be as much over the mountains as possible (excluding the apply button cause the contrast is high enough)? Worst case I could extend the sky for medium screens so we don't have to worry about text resizing. |
Do you think this should be a seperate issue or it must be fixed in this PR |
|
For readability sake I think it should be fixed in this PR. |
Yeah it should be ok! |
cool ty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for all the work guys!
There are a couple of changes that still need to be made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me!
No description provided.