refactor: simplify expressions #3281
Open
+49
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
roeap,
rtyler and
hntd187
as code owners
ion-elgreco
force-pushed
the
refactor--simplify-expressions-before-passing-them-around
branch
from
d484c5a to
49f32db
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3281 +/- ##
==========================================
- Coverage 72.14% 72.13% -0.01%
==========================================
Files 143 143
Lines 45624 45641 +17
Branches 45624 45641 +17
==========================================
+ Hits 32915 32923 +8
- Misses 10621 10625 +4
- Partials 2088 2093 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ion Koutsouris <[email protected]>
ion-elgreco
force-pushed
the
refactor--simplify-expressions-before-passing-them-around
branch
from
49f32db to
7a51022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During merge we should simplify the expression before creating the commit predicate. Additionally, inside the DeltaScan we also need to simplify the expression to improve the pruning.
This doesn't fully fix it but discussing the issue here: apache/datafusion#14944