docs: update CONTRIBUTING.md and Makefile to account for switch to uv #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreeve
requested review from
wjones127,
fvaleye,
roeap and
ion-elgreco
as code owners
github-actions
bot
added
binding/python
adamreeve
force-pushed
the
contributing-fix
branch
from
f3f2971 to
9d6e69b
Compare
Signed-off-by: Adam Reeve <[email protected]>
adamreeve
force-pushed
the
contributing-fix
branch
from
9d6e69b to
48fc7b8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3257 +/- ##
=======================================
Coverage 72.20% 72.20%
=======================================
Files 143 143
Lines 45607 45607
Branches 45607 45607
=======================================
Hits 32930 32930
Misses 10595 10595
Partials 2082 2082 ☔ View full report in Codecov by Sentry. |
ion-elgreco
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wanted to start developing delta-rs and found CONTRIBUTING.md confusing as it asks you to create a Python virtualenv that is never used. This updates the documentation to account for the switch to uv.
This was partly addressed previously in #3085.