Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: more manual inline format args #3251

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Feb 22, 2025

Manually fixed format argument inlining to improve readability, and fix a few minor related styling issues like trailing commas in a single line.

Note that in many places I have removed the & because it is rarely needed in a format arg, but makes code run ~5% slower (compiler cannot yet eliminate that)

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate proofs labels Feb 22, 2025
@nyurik nyurik force-pushed the fmt-inline2 branch 2 times, most recently from 298bc3e to 13facb8 Compare February 22, 2025 23:49
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 34.37500% with 63 lines in your changes missing coverage. Please review.

Project coverage is 72.09%. Comparing base (3a98143) to head (eef9b34).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/protocol/parquet_read/mod.rs 0.00% 13 Missing ⚠️
crates/core/src/operations/load_cdf.rs 0.00% 4 Missing and 3 partials ⚠️
crates/core/src/protocol/checkpoints.rs 0.00% 3 Missing and 3 partials ⚠️
crates/lakefs/src/client.rs 58.33% 0 Missing and 5 partials ⚠️
crates/core/src/operations/cast/mod.rs 0.00% 4 Missing ⚠️
crates/catalog-unity/src/lib.rs 25.00% 3 Missing ⚠️
crates/core/src/operations/optimize.rs 0.00% 1 Missing and 2 partials ⚠️
python/src/schema.rs 0.00% 3 Missing ⚠️
crates/catalog-unity/src/datafusion.rs 0.00% 2 Missing ⚠️
crates/core/src/kernel/snapshot/log_data.rs 0.00% 2 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3251      +/-   ##
==========================================
+ Coverage   72.05%   72.09%   +0.04%     
==========================================
  Files         143      143              
  Lines       45586    45530      -56     
  Branches    45586    45530      -56     
==========================================
- Hits        32845    32824      -21     
+ Misses      10665    10622      -43     
- Partials     2076     2084       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Manually fixed format argument inlining to improve readability, and fix a few minor related styling issues like trailing commas in a single line.

Signed-off-by: Yuri Astrakhan <[email protected]>
Signed-off-by: Yuri Astrakhan <[email protected]>
@ion-elgreco ion-elgreco added this pull request to the merge queue Feb 25, 2025
Merged via the queue into delta-io:main with commit 6b86c75 Feb 25, 2025
28 checks passed
@nyurik nyurik deleted the fmt-inline2 branch February 25, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate proofs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants