fix: MSRV fix by pinning idna_adapter version #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
=======================================
Coverage 84.02% 84.02%
=======================================
Files 77 77
Lines 18063 18063
Branches 18063 18063
=======================================
Hits 15178 15178
Misses 2167 2167
Partials 718 718 ☔ View full report in Codecov by Sentry. |
nicklan
requested changes
Mar 1, 2025
kernel/Cargo.toml
Outdated
| # force URL to use unicode-rs instead of ICU4X otherwise we require MSRV 1.81 | ||
| # from docs: compared to ICU4X, this makes build times faster, MSRV lower, binary size larger, and | ||
| # run-time performance slower. | ||
| idna_adapter = "=1.1.0" |
There was a problem hiding this comment.
We don't want to force this here, because then everyone depending on us is required to use this version. But, we can do it like I do with the home crate below. so, remove the url = "2" line and add:
[dependencies.url]
version = "2"
idna_adapter = "=1.1.0"below
There was a problem hiding this comment.
hm it seems this doesn't force that version (just pulling in 1.2 still)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
TLDR: pin
idna_adapterto version1.1.0.problem: despite Url saying that MSRV is 1.63, it actually depends on the unicode backend you use. previously kernel took no opinion and was thus bumped to the newest releases of ICU4X which requires rust 1.81. for now, we will force the old unicode backend and then in 0.8.0 (or whenever we want to bump MSRV) upgrade/revert back to the ICU4X backend
from Url docs:
How was this change tested?