-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.7.0 #716
Release 0.7.0 #716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with one nit. thanks!
CHANGELOG.md
Outdated
- Adds a new `scan::state::transform_to_logical` function that encapsulates the boilerplate of applying the transform expression | ||
- Removes `scan_action_iter` API and `logical_to_physical` API | ||
- Removes `column_mapping_mode` from `GlobalScanState` | ||
- ffi: Removes `add_partition_columns` in arrow.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, this isn't an "ffi" change, it's a change in the example program
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yep good catch thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i made the changes to arrow.c
as 'read-table example' changes and the other bullet as FFI
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
+ Coverage 84.01% 84.03% +0.02%
==========================================
Files 77 77
Lines 18063 18063
Branches 18063 18063
==========================================
+ Hits 15175 15179 +4
+ Misses 2167 2165 -2
+ Partials 721 719 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
included that last change to make everything green: |
release 0.7.0