feat!(ffi): new visit_schema FFI and rename old visit_schema to visit_snapshot_schema #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachschuermann
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
- Coverage 84.27% 84.22% -0.06%
==========================================
Files 77 77
Lines 17950 17960 +10
Branches 17950 17960 +10
==========================================
- Hits 15127 15126 -1
- Misses 2107 2119 +12
+ Partials 716 715 -1 ☔ View full report in Codecov by Sentry. |
scovich
approved these changes
Feb 7, 2025
OussamaSaoudi
requested changes
Feb 12, 2025
OussamaSaoudi
approved these changes
Feb 19, 2025
zachschuermann
added a commit
that referenced
this pull request
Feb 21, 2025
## What changes are proposed in this pull request? This PR removes the old `visit_snapshot_schema` introduced in #683 - we should just go ahead and do the 'right thing' with having a `visit_schema` (introduced in the other PR) and a `logical_schema()` function (added here) in order to facilitate visiting the snapshot schema. Additionally I've moved the schema-related things up from `scan` module to top-level in ffi crate. Exact changes listed below; this PR updates tests/examples to leverage the new changes. ### This PR affects the following public APIs 1. Remove `visit_snapshot_schema()` API 2. Add a new `logical_schema(snapshot)` API so you can get the schema of a snapshot and use the `visit_schema` directly 3. Renames `free_global_read_schema` to just `free_schema` 4. Moves `SharedSchema` and `free_schema` up from `mod scan` into top-level `ffi` crate. ## How was this change tested? existing UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
When given a schema (e.g. in
global_scan_state) the engine needs a way to visit this schema. This introduces a new APIvisit_schemato allow engines to visit any schema over FFI. An API calledvisit_schemapreviously existed but visited the schema of a given snapshot; this has now been renamed tovisit_snapshot_schema.This PR affects the following public APIs
Renamed
visit_schematovisit_snapshot_schemaand nowvisit_schematakesSharedSchemaas an argument instead of a snapshot.How was this change tested?
updated read_table test