Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cargo fmt does not handle mods defined in macros #676

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

roeap
Copy link
Collaborator

@roeap roeap commented Feb 4, 2025

What changes are proposed in this pull request?

Apparently cargo fmt does not work on modules defined in macros, which we were doing in some places. I don't think this fixes all the misses we have been seeing with cargo fmt, but should fix some of them.

How was this change tested?

just formatting existing code.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 68.35443% with 25 lines in your changes missing coverage. Please review.

Project coverage is 84.08%. Comparing base (e2378a5) to head (24d3a06).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/engine/arrow_data.rs 51.21% 19 Missing and 1 partial ⚠️
kernel/src/engine/ensure_data_types.rs 77.27% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
- Coverage   84.11%   84.08%   -0.03%     
==========================================
  Files          77       77              
  Lines       17779    17761      -18     
  Branches    17779    17761      -18     
==========================================
- Hits        14955    14935      -20     
- Misses       2110     2114       +4     
+ Partials      714      712       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good, but I don't know the answer to the question about the arrow-expression vs. engine feature configs.

@roeap roeap merged commit 379f5e5 into delta-io:main Feb 5, 2025
19 of 21 checks passed
@roeap roeap deleted the chore/fmt branch February 5, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants