-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create InvalidCheckpoint Error to bucket errors relevant to checkpoint #593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for proposing this change, it looks great.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
- Coverage 83.47% 83.46% -0.01%
==========================================
Files 74 74
Lines 16889 16893 +4
Branches 16889 16893 +4
==========================================
+ Hits 14098 14100 +2
- Misses 2132 2135 +3
+ Partials 659 658 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks this is a good idea - just a small nit but otherwise LGTM!
Co-authored-by: Zach Schuermann <[email protected]>
Co-authored-by: Zach Schuermann <[email protected]>
Tested msrv locally, not sure why the test is failing |
Thanks for the contribution! |
What changes are proposed in this pull request?
Create a new variation of error: InvalidCheckpoint error to bucket errors relevant to invalid checkpoint files. This will allow for a more flexible handling of checkpoint related errors when using delta kernel crate.
How was this change tested?
Via
cargo t --all-features --all-targets