Remove lifetime requirement on Scan::execute
#588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 83.44% 83.47% +0.02%
==========================================
Files 74 74
Lines 16861 16867 +6
Branches 16861 16867 +6
==========================================
+ Hits 14069 14079 +10
+ Misses 2132 2130 -2
+ Partials 660 658 -2 ☔ View full report in Codecov by Sentry. |
OussamaSaoudi-db
requested review from
nicklan,
scovich and
zachschuermann
and removed request for
nicklan and
scovich
OussamaSaoudi-db
force-pushed
the
scan_remove_lifetime
branch
from
8748e8a to
bb3704b
Compare
nicklan
approved these changes
Dec 11, 2024
zachschuermann
approved these changes
Dec 11, 2024
| )?; | ||
|
|
||
| // Arc clones | ||
| let engine = engine.clone(); | ||
| let global_state = global_state.clone(); | ||
| let all_fields = all_fields.clone(); |
There was a problem hiding this comment.
we clone here and above: can we get by with just one?
There was a problem hiding this comment.
I don't think so 😔 Both closures are move, so each closure wants ownership of its own all_fields. We'll eventually be able to avoid the clone by moving the construction of P2L expression evaluator out of the inner loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Currently,
Scan::executetakes the lifetime of theScaninto the Iterator, forcing it to live as long as the scan. This Pr removes that requirement so that the user can lazily consume the iterator without managing the lifetime ofScan. This simplifies the usage of kernelThis PR also changes all
read_schemanames tophysical_schemato make it clear and consistent what the schema represents. note thatSnapshotalready calls this thephysical_schemaThis PR affects the following public APIs
Scan::executeno longer depends on the lifetime of&selfHow was this change tested?
Everything compiles :)