Skip to content

Commit

Permalink
fix: remove column mapping default (#562)
Browse files Browse the repository at this point in the history
previously I accidentally changed default from `None` to `Name`. Instead
of simply reverting, this removes `Default` from column mapping
entirely.
  • Loading branch information
zachschuermann authored Dec 6, 2024
1 parent 136a59e commit 695b841
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions kernel/src/table_features/column_mapping.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use serde::{Deserialize, Serialize};
use strum::EnumString;

/// Modes of column mapping a table can be in
#[derive(Debug, Default, EnumString, Serialize, Deserialize, Copy, Clone, PartialEq, Eq)]
#[derive(Debug, EnumString, Serialize, Deserialize, Copy, Clone, PartialEq, Eq)]
#[strum(serialize_all = "camelCase")]
#[serde(rename_all = "camelCase")]
pub enum ColumnMappingMode {
Expand All @@ -20,7 +20,6 @@ pub enum ColumnMappingMode {
/// Columns are mapped by their field_id in parquet
Id,
/// Columns are mapped to a physical name
#[default]
Name,
}

Expand Down

0 comments on commit 695b841

Please sign in to comment.