Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies and tidy up build logic #100

Conversation

kingsleyadio
Copy link
Contributor

@kingsleyadio kingsleyadio commented Jan 25, 2025

This PR is intended to upgrade the dependencies and tidy up a few other build logic. It also fixes a compatibility problem with Kotlin 2.1+

Upgrades:

  • Upgrades Gradle to 8.12.1 (build only)
  • AGP to 8.8 (build only)
  • maven-publish to 0.30.0 (build only)
  • Kotlin to 2.0 (finally, this also makes it possible to upgrade to the new compose compiler)
  • Dagger to 2.53 (fixes a kotlin metadata build error when using Kotlin 2.1+)
  • Anvil to 2.5.1 (previously on a beta version)
  • Other deps were upgraded to approximately latest major - 1 versions since I don't want to force all consumers to deal with potential restrictions that may come with this. E.g some androidx libs now require consumers to also upgrade their compile SDK
  • Upgraded library's compile SDK to 35 (this is purely build only and doesn't affect library's runtime)

Build logic cleanup:

  • Introduced a new build-logic plugin to configure the runtime modules. This helps avoid the need for subproject config and also sets the project up for Gradle's project isolation
  • Cleanup root build.gradle.kts and replace the buildscript block with plugins DSL
  • Remove unnecessary kapt configs in whetstone-gradle-plugin
  • Tidy up toolchains configuration

By the way, the changes in apiDump doesn't affect whetstone's public API. They are changes from Anvil's generated hints as mentioned in the release notes

Please let me know if there's anything else I might need to do to get this landed.

Thanks.

Copy link
Collaborator

The changes look good. I'll review and drop any comments I have. Thanks. 👍🏾

@helios66 helios66 changed the base branch from main to task/update-kotlin-2.0/REL-684 January 27, 2025 15:25
@helios66 helios66 merged commit cccafb5 into deliveryhero:task/update-kotlin-2.0/REL-684 Jan 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants