pkp#10630 Review Fixes

defstat · Dec 19, 2024 · 230f25a · 230f25a
1 parent 558521a
commit 230f25a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/classes/invitation/core/InvitationActionRedirectController.php b/classes/invitation/core/InvitationActionRedirectController.php
@@ -18,8 +18,12 @@
 use Illuminate\Routing\Controller;
 use PKP\invitation\core\enums\InvitationAction;
 
+/**
+ * @template TInvitation of Invitation
+ */
 abstract class InvitationActionRedirectController extends Controller
 {
+    /** @var TInvitation */
     protected Invitation $invitation;
 
     public function __construct(Invitation $invitation)

diff --git a/...on/invitations/userRoleAssignment/handlers/UserRoleAssignmentInviteRedirectController.php b/...on/invitations/userRoleAssignment/handlers/UserRoleAssignmentInviteRedirectController.php
@@ -23,6 +23,9 @@
 use PKP\invitation\stepTypes\AcceptInvitationStep;
 use APP\facades\Repo;
 
+/**
+ * @extends InvitationActionRedirectController<UserRoleAssignmentInvite>
+ */
 class UserRoleAssignmentInviteRedirectController extends InvitationActionRedirectController
 {
     public function getInvitation(): UserRoleAssignmentInvite

diff --git a/.../invitations/userRoleAssignment/resources/UserRoleAssignmentInviteManagerDataResource.php b/.../invitations/userRoleAssignment/resources/UserRoleAssignmentInviteManagerDataResource.php
@@ -16,7 +16,6 @@
 
 use Illuminate\Http\Request;
 use PKP\invitation\invitations\userRoleAssignment\payload\UserRoleAssignmentInvitePayload;
-use PKP\user\User;
 
 class UserRoleAssignmentInviteManagerDataResource extends BaseUserRoleAssignmentInviteResource
 {