feat: add wonderGovernor and wonderVotes contract examples #5
Conversation
Signed-off-by: 0xRaccoon <raccoon@defi.sucks>
Signed-off-by: 0xRaccoon <raccoon@defi.sucks>
|
|
||
| function quorum(uint256 _timepoint, uint8 _proposalType) public view override returns (uint256) { | ||
| // same quorum for all proposals types and timepoints | ||
| return 400_000e18; |
There was a problem hiding this comment.
it would be cool to see some example where this has logic, like a percentage of IERC20(VoteToken).totalSupply()
There was a problem hiding this comment.
For another instance, ofc
There was a problem hiding this comment.
Exactly, this could be calling votes.getPastTotalSupply(_proposalType, _timepoint) and calculate a percentage of that, or it could also combine with the total supply to ensure that a minimum threshold of voting power is being tracked for new proposal types.
| } | ||
|
|
||
| function _weightNormalizer() internal view virtual override returns (uint256) { | ||
| return 100; |
There was a problem hiding this comment.
can't we just use a state variable instead of a function for this? use the getter
There was a problem hiding this comment.
Yes, we could. But that will require us to change the WonderVotes parent contract and use a variable we would override or change in the child contract instead a function. I think a function ensures that the child will override it by not having it implemented in the parent contract. We can change this one if we consider that is more convenient constant in a next pr.
No description provided.