-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: self-hosted hasura for DataLayer graphql API #23
Conversation
docker-compose.yaml
Outdated
HASURA_GRAPHQL_DEV_MODE: ${DATALAYER_HASURA_DEV_MODE:-true} | ||
HASURA_GRAPHQL_ENABLED_LOG_TYPES: "startup, http-log, webhook-log, websocket-log, query-log" | ||
HASURA_GRAPHQL_ENABLED_APIS: "graphql,metrics" | ||
HASURA_GRAPHQL_ADMIN_INTERNAL_ERRORS: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we default this to false? would not want to expose prod info by accident
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right
DATALAYER_HASURA_UNAUTHORIZED_ROLE=public | ||
DATALAYER_HASURA_CORS_DOMAIN=* | ||
DATALAYER_HASURA_ENABLE_TELEMETRY=false | ||
# HASURA_GRAPHQL_METADATA_DATABASE_EXTENSIONS_SCHEMA: "chain_data_schema_1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some explanation of this might be useful--or do you think it would be clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll add a link to Hasura docs explaining each variable
docker-compose.yaml
Outdated
retries: 5 | ||
|
||
api-hasura: | ||
image: hasura/graphql-engine:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure you don't want to pin a version to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
docker-compose.yaml
Outdated
timeout: 5s | ||
retries: 5 | ||
|
||
api-hasura: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets pick more descriptive namings here
instead of api-hasura
=> datalayer-api
instead of graphql-engine
=> indexer-api
instead of envio-postgres
=> indexer-db
instead of datalayer-postgres
=> datalayer-db
lmk wdyt : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree on making them more descriptive but i like the tech being on the name
datalayer-graphql-api
indexer-postgres-db
but we can go with your naming too, don't have any particular preference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets do it in that way :)
🤖 Linear
Closes GIT-76 GIT-77
Description
Note: this Hasura is a different service from the one that gets exposed for Envio