fix: use keccak chain ID #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnigir1
reviewed
Oct 14, 2024
Comment on lines
58
to
65
| public static findByHash( | ||
| hashedChainId: Hex, | ||
| chainIds: Caip2ChainId[], | ||
| ): Caip2ChainId | undefined { | ||
| return chainIds.find( | ||
| (id) => keccak256(toHex(id)).toLowerCase() === hashedChainId.toLowerCase(), | ||
| ); | ||
| } |
There was a problem hiding this comment.
it's not a general solution, but since you use the constant EBO_SUPPORTED_CHAIN_IDS, isn't it possible to have a map (hash => Caip2ChainId) ? it's more efficient
jahabeebs
reviewed
Oct 14, 2024
| @@ -1,6 +1,7 @@ | |||
| import { EboActorsManager, EboProcessor, ProtocolProvider } from "@ebo-agent/automated-dispute"; | |||
| import { BlockNumberService, Caip2ChainId } from "@ebo-agent/blocknumber"; | |||
| import { Logger } from "@ebo-agent/shared"; | |||
| import { DiscordNotifier } from "@ebo-agent/automated-dispute/dist/services/discordNotifier.js"; | |||
There was a problem hiding this comment.
Did you mean to import from dist?
0xnigir1
approved these changes
Oct 15, 2024
jahabeebs
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-212, GRT-89
Description
RequestCreatedevent that comes with the chain ID hash, we need to find which no-hashed chain ID is the correct one by comparing all chain ID hashes with the one received via event.sharedpackage