feat: skip unsupported chains #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnigir1
previously approved these changes
Sep 17, 2024
| event: EboEvent<EboEventName>, | ||
| ): event is EboEvent<"RequestCreated"> => { | ||
| return event.name === "RequestCreated"; | ||
| }; |
0xkenj1
previously approved these changes
Sep 17, 2024
| if (this.isChainSupported(chainId)) { | ||
| this.logger.info(`Creating a new EboActor to handle request ${requestId}...`); | ||
|
|
||
| return this.createNewActor(firstEvent as EboEvent<"RequestCreated">); |
There was a problem hiding this comment.
Suggested change
| return this.createNewActor(firstEvent as EboEvent<"RequestCreated">); | |
| return this.createNewActor(firstEvent); |
There was a problem hiding this comment.
Whoops, nice catch! Wrote this before adding the typeguard
jahabeebs
previously approved these changes
Sep 17, 2024
|
|
||
| return this.createNewActor(firstEvent as EboEvent<"RequestCreated">); | ||
| if (this.isChainSupported(chainId)) { |
There was a problem hiding this comment.
optional: could probably move this into the outer if { } to avoid nesting
There was a problem hiding this comment.
It might be a little bit cumbersome for both supported and unsupported cases. I need to be sure first that the event is a RequestCreated event to access the chainId.
if (firstEvent && isRequestCreatedEvent(firstEvent) && this.isChainSupported(firstEvent.metadata.chainId)) {
...
} else if (firstEvent && isRequestCreatedEvent(firstEvent) && !this.isChainSupported(firstEvent.metadata.chainId) {
...
} ...
jahabeebs
approved these changes
Sep 17, 2024
0xnigir1
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-144
Description