Update torch.norm to torch.linalg.norm and torch.linalg.vector_norm
#6931
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
changed the title
torch.norm to torch.linalg.norm
loadams
requested review from
tjruwase,
tohtana and
GuanhuaWang
as code owners
loadams
changed the title
torch.norm to torch.linalg.normtorch.norm to torch.linalg.norm and torch.linalg.vector_norm
tohtana
approved these changes
Jan 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
siqi654321
pushed a commit
to siqi654321/DeepSpeed
that referenced
this pull request
Feb 7, 2025
…orm` (deepspeedai#6931) - [x] Update PR since `torch.norm` and `torch.linalg.norm` have [different function signatures](https://pytorch.org/docs/stable/generated/torch.linalg.norm.html#torch.linalg.norm). - [x] Check if there are any numeric differences between the functions. - [x] Determine why there appear to be performance differences from others [here](pytorch/pytorch#136360). - [x] Update to `torch.linalg.vectornorm` Follow up PR handles these in the comm folder: deepspeedai#6960 Signed-off-by: siqi <[email protected]>
traincheck-team
pushed a commit
to traincheck-team/DeepSpeed
that referenced
this pull request
Feb 9, 2025
…orm` (deepspeedai#6931) - [x] Update PR since `torch.norm` and `torch.linalg.norm` have [different function signatures](https://pytorch.org/docs/stable/generated/torch.linalg.norm.html#torch.linalg.norm). - [x] Check if there are any numeric differences between the functions. - [x] Determine why there appear to be performance differences from others [here](pytorch/pytorch#136360). - [x] Update to `torch.linalg.vectornorm` Follow up PR handles these in the comm folder: deepspeedai#6960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torch.normandtorch.linalg.normhave different function signatures.torch.linalg.vectornormFollow up PR handles these in the comm folder: Explicitly use the linalg.vector_norm call in
comm/#6960