-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: unpin numpy
+ use Python 3.9 in CI
#8492
Conversation
Pull Request Test Coverage Report for Build 11502851488Details
💛 - Coveralls |
numpy
+ use Python 3.9 in CI
"spacy>=3.8,<3.9", | ||
"spacy-curated-transformers>=0.2,<=0.3", | ||
"en-core-web-trf @ https://github.com/explosion/spacy-models/releases/download/en_core_web_trf-3.7.3/en_core_web_trf-3.7.3-py3-none-any.whl", | ||
"en-core-web-trf @ https://github.com/explosion/spacy-models/releases/download/en_core_web_trf-3.8.0/en_core_web_trf-3.8.0-py3-none-any.whl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous spacy
dependencies required numpy<2
, while these require numpy>=2
@@ -81,6 +81,8 @@ format-check = "ruff format --check {args}" | |||
|
|||
[tool.hatch.envs.test] | |||
extra-dependencies = [ | |||
"numpy>=2", # Haystack is compatible both with numpy 1.x and 2.x, but we test with 2.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this pin is not strictly required (see the comment on spacy
), but I have included it for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Related Issues
numpy 2
compatible #8474numpy<2
to avoid failures in several core integrations.Proposed Changes:
numpy
: its usage in Haystack is compatible with both 1.x and 2.xnumpy>=2
in CInumpy>=2
How did you test it?
CI
Core integrations
In general, I think that if some of the core integrations break we will find out because on the nightly tests of core integrations we also test with Haystack main branch. In that case, we can pin numpy specifically where required.
To be on the safe side, I ran the following script locally (with Python 3.10, Ubuntu 22.04) from core integrations root directory and got no failures.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.