Move dict creation outside of for loop

deepset-ai · Feb 10, 2025 · dc12957 · dc12957
1 parent ca20f74
commit dc12957
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/haystack/components/preprocessors/csv_document_splitter.py b/haystack/components/preprocessors/csv_document_splitter.py
@@ -86,15 +86,11 @@ def run(self, documents: List[Document]) -> Dict[str, List[Document]]:
         if len(documents) == 0:
             return {"documents": documents}
 
+        resolved_read_csv_kwargs = {"header": None, "skip_blank_lines": False, "dtype": object, **self.read_csv_kwargs}
+
         split_documents = []
         for document in documents:
             try:
-                resolved_read_csv_kwargs = {
-                    "header": None,
-                    "skip_blank_lines": False,
-                    "dtype": object,
-                    **self.read_csv_kwargs,
-                }
                 df = pd.read_csv(StringIO(document.content), **resolved_read_csv_kwargs)  # type: ignore
             except Exception as e:
                 logger.error(f"Error processing document {document.id}. Keeping it, but skipping splitting. Error: {e}")