Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(): add e2e playwright test #3

Merged
merged 11 commits into from
Dec 16, 2024
Merged

ci(): add e2e playwright test #3

merged 11 commits into from
Dec 16, 2024

Conversation

ShaMan123
Copy link
Contributor 

npm i
npx playwright install --with-deps chromium

@ShaMan123 ShaMan123 force-pushed the ci/test branch 2 times, most recently from 2ddd6d4 to db5e23f Compare December 16, 2024 17:55
ShaMan123
ShaMan123 commented Dec 16, 2024
View reviewed changes
Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working for some reason

@Dexus
Copy link
Member

Dexus commented Dec 16, 2024

I will check this later, if you do not have luck to fix it.

@ShaMan123 ShaMan123 force-pushed the ci/test branch 2 times, most recently from 9c52809 to 208ffb1 Compare December 16, 2024 18:20
@Dexus
Copy link
Member

Dexus commented Dec 16, 2024

Possible : https://playwright.dev/docs/api/class-electron the known issue? Would make sense for me.

Will check later.

ShaMan123
ShaMan123 commented Dec 16, 2024
View reviewed changes
Copy link
Contributor Author

@ShaMan123 ShaMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing!
Ubuntu 24 issue resolved

@ShaMan123
Copy link
Contributor Author

Squash and merge please

@Dexus Dexus merged commit 47f3f9a into main Dec 16, 2024
7 checks passed
@Dexus
Copy link
Member

Dexus commented Dec 16, 2024

Thank you @ShaMan123

@Dexus Dexus deleted the ci/test branch December 16, 2024 19:50
@ShaMan123
Copy link
Contributor Author

My pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaMan123 @Dexus