-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve neighbor stat log #4561
Conversation
Signed-off-by: Jinzhe Zeng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
deepmd/utils/neighbor_stat.py:85
- The str() conversion for max_nbor_size is unnecessary and can be directly included in the f-string.
log.info(f"Neighbor statistics: training data with maximum neighbor size: {str(max_nbor_size)} (cutoff radius: {self.rcut:f})")
for more information, see https://pre-commit.ci
📝 WalkthroughWalkthroughThe pull request introduces modifications to the logging statements in the Changes
Note: No changes were made to method signatures, parameters, or return types, and the underlying logic of the method remains the same. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (19)
🔇 Additional comments (1)
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #4561 +/- ##
==========================================
- Coverage 84.60% 84.60% -0.01%
==========================================
Files 680 680
Lines 64468 64469 +1
Branches 3538 3539 +1
==========================================
- Hits 54546 54545 -1
- Misses 8781 8782 +1
- Partials 1141 1142 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Summary by CodeRabbit
NeighborStat
class for better clarity and detail