fix(pt): fix clearing the list in set_eval_descriptor_hook #4534
Conversation
Fix deepmodeling#4533. Signed-off-by: Jinzhe Zeng <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
📝 WalkthroughWalkthroughThe pull request involves two files: Changes
Assessment against linked issues
The changes seem to be preliminary steps towards addressing the bug reported in issue #4533, but more investigation would be needed to confirm if the root cause has been fully resolved. The modification in Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/tests/infer/test_models.py (1)
162-165: Consider avoiding duplicated assertion logic.
These lines repeat the same descriptor evaluation and comparison without providing additional coverage. You could remove or refactor them for clarity.- # See #4533 - descpt = self.dp.eval_descriptor(result.coord, result.box, result.atype) - expected_descpt = result.descriptor - np.testing.assert_almost_equal(descpt.ravel(), expected_descpt.ravel())
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
deepmd/pt/model/atomic_model/dp_atomic_model.py(1 hunks)source/tests/infer/test_models.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: Build wheels for cp311-macosx_x86_64
- GitHub Check: Test Python (3, 3.12)
- GitHub Check: Test Python (3, 3.9)
- GitHub Check: Test Python (2, 3.12)
- GitHub Check: Build C++ (rocm, rocm)
- GitHub Check: Analyze (python)
- GitHub Check: Test Python (2, 3.9)
- GitHub Check: Build C++ (cuda120, cuda)
- GitHub Check: Test Python (1, 3.12)
- GitHub Check: Test Python (1, 3.9)
- GitHub Check: Analyze (c-cpp)
- GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
🔇 Additional comments (1)
deepmd/pt/model/atomic_model/dp_atomic_model.py (1)
72-73: Use ofclear()instead of reassigning an empty list is appropriate.
This change ensures that references toeval_descriptor_listremain valid while still resetting its contents.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #4534 +/- ##
==========================================
- Coverage 84.57% 84.57% -0.01%
==========================================
Files 675 675
Lines 63695 63695
Branches 3488 3487 -1
==========================================
- Hits 53872 53871 -1
Misses 8698 8698
- Partials 1125 1126 +1 ☔ View full report in Codecov by Sentry. |
Fix #4533.
Summary by CodeRabbit
DPAtomicModelclassTestDeepPot