Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor:remove GlobalC::ucell in module_ri #5698

Merged
merged 25 commits into from
Dec 10, 2024

Conversation

A-006
Copy link
Collaborator

@A-006 A-006 commented Dec 9, 2024

What's changed?

  • Remove Ucell in EXX and module_ri
  • Remove GlobalC::ucell in module_lcaodft with EXX
  • The contributeHR in module_lcaodft/operator_lcao/op_exx_lcao.h need to override the vritual function.Thus i should change all the contributeHR with parameter ucell,so i add the const reference of ucell in this class.

@A-006 A-006 requested a review from maki49 December 9, 2024 08:00
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Dec 10, 2024
@mohanchen mohanchen merged commit 3afb499 into deepmodeling:develop Dec 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants