Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bfgs_trad method #5662

Merged
merged 9 commits into from
Dec 14, 2024
Merged

Conversation

19hello
Copy link
Collaborator

@19hello 19hello commented Dec 2, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

docs/advanced/opt.md Outdated Show resolved Hide resolved
docs/advanced/opt.md Outdated Show resolved Hide resolved
@mohanchen mohanchen added Refactor Refactor ABACUS codes GeometryRelaxation Issues related to geometry relaxation labels Dec 2, 2024
@QuantumMisaka
Copy link
Collaborator

@19hello Any updates ?

@mohanchen mohanchen merged commit c099d03 into deepmodeling:develop Dec 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GeometryRelaxation Issues related to geometry relaxation Refactor Refactor ABACUS codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants