Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix the stoi failure for output flag out_chg #5526

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

kirk0830
Copy link
Collaborator

@kirk0830 kirk0830 commented Nov 19, 2024

We still encourage user to use 1 or True, although there are more have been supported... secretely...

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #5523

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

We still encourage user to use `1` or `True`, although there are more has been supported... secretely...
@kirk0830 kirk0830 linked an issue Nov 19, 2024 that may be closed by this pull request
16 tasks
@mohanchen mohanchen merged commit 7ef0528 into develop Nov 19, 2024
25 checks passed
@mohanchen mohanchen added Input&Output Suitable for coders without knowing too many DFT details Refactor Refactor ABACUS codes labels Nov 19, 2024
@kirk0830 kirk0830 deleted the kirk0830-patch-1 branch November 19, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input&Output Suitable for coders without knowing too many DFT details Refactor Refactor ABACUS codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: out_chg cannot be set as boolean
2 participants