Fix Failed to stop the muxer (ref #139) #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mycohbasilan
approved these changes
Jan 18, 2022
This was referenced Jan 31, 2022
Closed
|
@natario1 |
|
Stacktrace: |
natario1
reviewed
Mar 12, 2022
Comment on lines
+42
to
52
| if (eos) { | ||
| info.set(0, 0, 0, flags and MediaCodec.BUFFER_FLAG_END_OF_STREAM) | ||
| } else { | ||
| info.set( | ||
| buffer.position(), | ||
| buffer.remaining(), | ||
| timestamp, | ||
| flags | ||
| ) | ||
| } | ||
| sink.writeTrack(track, buffer, info) |
There was a problem hiding this comment.
The last buffer might have data in theory, is it possible to send it in a separate call?
if (eos) {
if (buffer.hasRemaining()) {
info.set(buffer.position(), buffer.remaining(), timestamp, flags)
sink.writeTrack(track, buffer, info)
}
info.set(0, 0, 0, flags and MediaCodec.BUFFER_FLAG_END_OF_STREAM)
} else {
info.set(buffer.position(), buffer.remaining(), timestamp, flags)
}
sink.writeTrack(track, buffer, info)
Would this fix your crash?
There was a problem hiding this comment.
@natario1 Thanks for your review.
I tried your codes. But Crashed.
W/DefaultDataSink: Failed to release the muxer.
java.lang.IllegalStateException: Failed to stop the muxer
at android.media.MediaMuxer.nativeStop(Native Method)
at android.media.MediaMuxer.stop(MediaMuxer.java:466)
at android.media.MediaMuxer.release(MediaMuxer.java:706)
at com.otaliastudios.transcoder.sink.DefaultDataSink.release(DefaultDataSink.java:224)
at com.otaliastudios.transcoder.internal.transcode.DefaultTranscodeEngine.cleanup(DefaultTranscodeEngine.kt:141)
at com.otaliastudios.transcoder.internal.transcode.TranscodeEngine$Companion.transcode(TranscodeEngine.kt:63)
at com.otaliastudios.transcoder.internal.transcode.TranscodeEngine.transcode(Unknown Source:2)
at com.otaliastudios.transcoder.Transcoder$1.call(Transcoder.java:102)
at com.otaliastudios.transcoder.Transcoder$1.call(Transcoder.java:99)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:919)
|
Any update on this issue? |
MadCoderme
approved these changes
Jul 28, 2022
|
Please review and merge the changes, the library doesn't work in a lot of devices |
|
I'm not sure what the correct solution is. I don't have a crashing device, but it would be nice to know the API level and the values of |
|
@natario1 I am getting this error on Android 7.1, But i don't see this issue on android 12/13. Also it doesn't shows up for all vieos. |
|
any updates on this issue? |
|
In the meantime whoever wants this fix use: |
|
@UrielFrankel thanks for providing a fork. Do you think it's possible that you can create a new PR with a fix and get it merged? I did the same a few weeks ago: https://github.com/natario1/Transcoder/pull/182 and then released a new version: https://github.com/natario1/Transcoder/pull/183 This way the complex code that we have here is unified and everyone benefits from the fixes. |
|
@vanniktech this is not my fork, it is @jumperson code from above. |
|
Any update on this? |
natario1
force-pushed
the
fix-failed-to-the-stop-muxer
branch
from
d683aab to
f85b30d
Compare
|
Thanks! |
This was referenced Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
info.set(0, 0, 0, flags and MediaCodec.BUFFER_FLAG_END_OF_STREAM)is fine forEOS.Do you think it is correct ?
ref: #139