Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Long dashboard titles overflow the navbar tab #2348

Merged

Conversation

ericlln
Copy link
Contributor

@ericlln ericlln commented Jan 23, 2025

  • Moved the title into its own element in the navbar tab so that text-overflow: ellipsis would work properly.
  • Tested by creating dashboards with both long and short titles to confirm that long titles are truncated with ellipses, and short titles display in the same way as before.

@ericlln ericlln requested a review from mofojed January 23, 2025 17:04
@ericlln ericlln self-assigned this Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.76%. Comparing base (ae544fa) to head (35f1b11).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2348    +/-   ##
========================================
  Coverage   46.76%   46.76%            
========================================
  Files         710      710            
  Lines       39107    39107            
  Branches     9773     9958   +185     
========================================
  Hits        18288    18288            
  Misses      20808    20808            
  Partials       11       11            
Flag Coverage Δ
unit 46.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed requested review from dsmmcken and removed request for mofojed January 27, 2025 15:54
@mofojed
Copy link
Member

mofojed commented Jan 27, 2025

I'm assigning @dsmmcken for review as this is mainly a styling thing.

Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are truncating it we should also tooltip it so users can get the full name.

If the user has a dash:
my_long_dashboard_name_1
my_long_dashboard_name_2

There's no way to tell them apart.

@ericlln
Copy link
Contributor Author

ericlln commented Jan 27, 2025

Currently the Tooltip component is placed inside of the span for the title to make it appear only when the text is hovered, which prevents it from conflicting with the tooltip on the close button. On enterprise, there is no tooltip for the close button, and the tooltip is triggered by hovering over any part of the tab, rather than only the text.

@ericlln ericlln requested a review from dsmmcken January 28, 2025 15:52
@ericlln ericlln merged commit d1e345a into deephaven:main Jan 29, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants