-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Long dashboard titles overflow the navbar tab #2348
fix: Long dashboard titles overflow the navbar tab #2348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2348 +/- ##
========================================
Coverage 46.76% 46.76%
========================================
Files 710 710
Lines 39107 39107
Branches 9773 9958 +185
========================================
Hits 18288 18288
Misses 20808 20808
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm assigning @dsmmcken for review as this is mainly a styling thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we are truncating it we should also tooltip it so users can get the full name.
If the user has a dash:
my_long_dashboard_name_1
my_long_dashboard_name_2
There's no way to tell them apart.
Currently the |
text-overflow: ellipsis
would work properly.