Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix e2e logs #344

Merged
merged 7 commits into from
Mar 18, 2024
Merged

test: fix e2e logs #344

merged 7 commits into from
Mar 18, 2024

Conversation

wusteven815
Copy link
Contributor

@wusteven815 wusteven815 commented Mar 7, 2024

Since the Docker commands are being run in a new directory stack (by pushd), docker logs outside will show that the container is not found. Instead, the output is piped to a file in the run_docker script.

@wusteven815 wusteven815 self-assigned this Mar 7, 2024
@wusteven815 wusteven815 requested a review from mofojed March 7, 2024 17:56
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also creating the server-log.txt file in /tmp/server-log.txt when run locally as well... I don't really want to depend on the /tmp folder locally...
If you're giving the container a name in docker-compose.yml, it should still pick that up?

@wusteven815
Copy link
Contributor Author

This is also creating the server-log.txt file in /tmp/server-log.txt when run locally as well... I don't really want to depend on the /tmp folder locally... If you're giving the container a name in docker-compose.yml, it should still pick that up?

Figured it out, it was docker compose down deleting the containers.

@wusteven815 wusteven815 requested a review from mofojed March 13, 2024 15:20
@wusteven815 wusteven815 merged commit 174655d into deephaven:main Mar 18, 2024
9 checks passed
@wusteven815 wusteven815 deleted the e2e-logs branch March 18, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix E2E server log dumping
2 participants