Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for ServiceWorker #42

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix: check for ServiceWorker #42

merged 1 commit into from
Jun 5, 2024

Conversation

jnumainville
Copy link
Collaborator

fixes #41

@jnumainville jnumainville requested a review from mofojed June 5, 2024 19:20
@jnumainville jnumainville self-assigned this Jun 5, 2024
mofojed
mofojed approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure you could just check ServiceWorker !== undefined, but this works too.

@jnumainville jnumainville merged commit 657b497 into deephaven:main Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees

@jnumainville jnumainville

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ServiceWorker is not defined error
2 participants
@jnumainville @mofojed