fix: DH-18395: Address performance problems with large numbers of table locations caused by serial unmanage #6552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g columns. Avoid unnecessary queuing.
…age all buffered locations individually, as this is much more expensive than simply dropping all of them. * Fix TableLocationSubscriptionBuffer bug in add/remove validation. * Fix TableBackedTableLocationProvider to set callsite for instrumentation, so that many table ops in a tight loop are no longer quite so expensive.
rcaudy
changed the title
rcaudy
changed the title
cpwright
approved these changes
Jan 13, 2025
...main/java/io/deephaven/engine/table/impl/locations/impl/TableLocationSubscriptionBuffer.java
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the supplied "unit test" is maybe not suitable for commit.