fix: JS subscriptions should return correct size while updating (#6463) #6464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
jsapi
NoDocumentationNeeded
ReleaseNotesNeeded
mofojed
previously approved these changes
Dec 6, 2024
|
Not sure what's up with the failing tests... |
|
@niloc132 @dgodinez-dh found a new issue found with our e2e tests where our |
dgodinez-dh
requested changes
Dec 6, 2024
There was a problem hiding this comment.
We found an issue in deephaven.ui that we think is related to this change. Please wait to merge.
Here is the ticket:
https://deephaven.atlassian.net/browse/DH-18128
dgodinez-dh
approved these changes
Dec 10, 2024
mofojed
approved these changes
Dec 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6423
Fixes DH-18128
Backport #6463
Backport #6473