-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update projects that use Arrow 18 to require Java 11 #6417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised that gradle doesn't fail to build these JARS that target --release 8
; I would have thought / hoped that was the case? Does it implicitly upgrade them to --release 11
based on their dependencies?
I don't think we need / want to bump java-client-session / java-client-session-dagger to 11 since it should not depend on Arrow.
I think Gradle can only fail in that way if we could have gotten the
|
I would have hoped that the bytecode level of the JAR would be enough information to suss this out; if not via javac, then through gradle :/ Although, I guess technically, I can strongarm an argument for why it is the way it is: "Yes, I'm creating a Jar that only uses Java 8 features, and builds a Java 8 compatible Jar; and even though I depend directly/transitively on Java 11+ Jar, that's a concern for runtime, and shouldn't effect my Jar in isolation". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should file an issue that languageLevel
doesn't provide as strong as guarantees as I would have thought / hoped.
These projects depend directly or indirectly on Arrow v18 jars, which are compiled to require Java 11. Gradle correctly fails to build if a project depending on one of these still tries to use Java 8.
Follow-up #6347