feat: Add Parquet field_id writing #6381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for the writing of Parquet column field_ids. This is an extraction from deephaven#6156 (which will need to expose deeper hooks to allow Iceberg to fully control field_id resolution during reading). This is to ensure we can correctly write down Iceberg tables which must write field_ids which is necessary for deephaven#5989 In addition, it was noticed that Parquet ColumnMetaData encoding was written down in a non-deterministic order due to the use of a HashSet; it has been updated to an EnumSet to support a more consistent Parquet serialization. This was necessary to test out field_id writing.
devinrsmith
added
parquet
extensions/parquet/base/src/main/java/io/deephaven/parquet/base/ColumnWriterImpl.java
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetInstructions.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetInstructions.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/test/java/io/deephaven/parquet/table/ParquetInstructionsTest.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/test/java/io/deephaven/parquet/table/ParquetInstructionsTest.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/test/java/io/deephaven/parquet/table/TestParquetTools.java
Show resolved
Hide resolved
extensions/parquet/table/src/test/java/io/deephaven/parquet/table/TestParquetTools.java
Show resolved
Hide resolved
extensions/parquet/table/src/test/java/io/deephaven/parquet/table/TestParquetTools.java
Outdated
Show resolved
Hide resolved
malhotrashivam
previously approved these changes
Nov 18, 2024
rcaudy
reviewed
Nov 18, 2024
extensions/parquet/table/src/test/java/io/deephaven/parquet/table/TestParquetTools.java
Outdated
Show resolved
Hide resolved
extensions/parquet/table/src/test/java/io/deephaven/parquet/table/TestParquetTools.java
Show resolved
Hide resolved
rcaudy
reviewed
Nov 18, 2024
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetInstructions.java
Outdated
Show resolved
Hide resolved
rcaudy
approved these changes
Nov 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the writing of Parquet column field_ids.
This is an extraction from #6156 (which will need to expose deeper hooks to allow Iceberg to fully control field_id resolution during reading).
This is to ensure we can correctly write down Iceberg tables which must write field_ids which is necessary for #5989
In addition, it was noticed that Parquet ColumnMetaData encoding was written down in a non-deterministic order due to the use of a HashSet; it has been updated to an EnumSet to support a more consistent Parquet serialization. This was necessary to test out field_id writing.