-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add additional counting aggregations to AggBy
#6358
base: main
Are you sure you want to change the base?
Conversation
@Parameter | ||
public abstract AggCountType countType(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll post the same sort of concerns here that I have for #6270; I think we would do better to express this in terms of a Filter. What if I want to count NULL or NAN or INFINITE? Or any combination?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting idea, would prefer to see this as a new feature suggestion.
These agg_by
ops are companions to Numeric
/ Basic
vector ops (and will be paralleled by update_by
cum_count
and rolling_count
variants) and this filter idea isn't trivial to extend to all these routines.
engine/table/src/main/java/io/deephaven/engine/table/impl/by/BaseChunkedCountOperator.java
Outdated
Show resolved
Hide resolved
proto/proto-backplane-grpc/src/main/proto/deephaven/proto/table.proto
Outdated
Show resolved
Hide resolved
table-api/src/main/java/io/deephaven/api/agg/util/AggCountType.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/BaseChunkedCountOperator.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python changes LGTM
New aggregations are:
AggCountNonNull()
AggCountNull()
AggCountNegative()
AggCountPositive()
AggCountZero()
AggCountNaN()
AggCountInfinite()
AggCountFinite()