Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flight: Disable Batching Static Tables #4985

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Flight: Disable Batching Static Tables #4985

merged 2 commits into from
Jan 9, 2024

Conversation

nbauernfeind
Copy link
Member

The jsapi cannot handle multiple batches on static tables; note that refreshing tables are already disabled in this regard.

We'll have to disable batching static tables until after #188 is completed.

@nbauernfeind nbauernfeind added this to the December 2023 milestone Dec 22, 2023
@nbauernfeind nbauernfeind self-assigned this Dec 22, 2023
niloc132
niloc132 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server changes (and test) approved, tested locally with and without the client additions.

@nbauernfeind nbauernfeind enabled auto-merge (squash) January 9, 2024 22:13
@nbauernfeind nbauernfeind merged commit eabf2f3 into deephaven:main Jan 9, 2024
18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niloc132 niloc132 niloc132 approved these changes

Assignees

@nbauernfeind nbauernfeind

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
0. December 2023 (end of month)
Development

Successfully merging this pull request may close these issues.
2 participants
@nbauernfeind @niloc132