Skip to content

Commit

Permalink
Fix Server-Side ABORT That Should be CANCELLED (#5018)
Browse files Browse the repository at this point in the history
  • Loading branch information
nbauernfeind authored Jan 9, 2024
1 parent 3229d71 commit f9ee26a
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public synchronized void listFields(

synchronized void remove(Subscription sub) {
if (subscriptions.remove(sub)) {
sub.notifyObserverAborted();
sub.notifyObserverCancelled();
}
}

Expand Down Expand Up @@ -250,8 +250,8 @@ private boolean send(FieldsChangeUpdate changes) {
}

// must be sync wrt parent
private void notifyObserverAborted() {
GrpcUtil.safelyError(observer, Code.ABORTED, "subscription cancelled");
private void notifyObserverCancelled() {
GrpcUtil.safelyError(observer, Code.CANCELLED, "subscription cancelled");
}
}

Expand Down

0 comments on commit f9ee26a

Please sign in to comment.